[
https://issues.apache.org/jira/browse/HCATALOG-573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13555210#comment-13555210
]
Travis Crawford commented on HCATALOG-573:
------------------------------------------
A couple minor suggestions, but in general this is a good change.
* Please update the function comment to say it prints the path of the webhcat
jar (currently says "finds" which I had to go elsewhere to see how its called.
With bash not supporting string return values I had to go look at how this is
called to understand what's expected of the function.
* How about moving this check into {{find_jar_path}}, instead of checking the
printed value after calling. This way we can centralize all the checks, which
should make it more clear to readers of the script.
{code}
if [[ -z "$JAR" ]]; then
die "No webhcat jar found"
fi
{code}
> Remove version number from WEBHCAT_JAR in webhcat_config.sh
> -----------------------------------------------------------
>
> Key: HCATALOG-573
> URL: https://issues.apache.org/jira/browse/HCATALOG-573
> Project: HCatalog
> Issue Type: Bug
> Components: webhcat-svr
> Reporter: Thejas M Nair
> Assignee: Thejas M Nair
> Fix For: 0.5
>
> Attachments: HCATALOG-573.1.patch
>
>
> In webhcat_config.sh, WEBHCAT_JAR variable is set to webhcat jar name ,
> which includes the version number.
> This means that the code has to change each time a new release (with new
> version no) happens.
> It should instead use a regex to match jar of current version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
