[
https://issues.apache.org/jira/browse/HCATALOG-573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13555440#comment-13555440
]
Thejas M Nair commented on HCATALOG-573:
----------------------------------------
bq. Please update the function comment to say it prints the path of the
webhcat jar (currently says "finds" which I had to go elsewhere to see how its
called. With bash not supporting string return values I had to go look at how
this is called to understand what's expected of the function.
Updated the comment in HCATALOG-573.2.patch.
bq. How about moving this check into find_jar_path, instead of checking the
printed value after calling. This way we can centralize all the checks, which
should make it more clear to readers of the script.
The script is checking for return values of function calls in the 'main'
section. So this would be consistent with rest of the script. But my main
concern is that we would like to get this in by today in time for hcat 0.5
release. Given that this is a minor issue and my (lack of) expertise with bash
script, I think it is better to defer this change.
> Remove version number from WEBHCAT_JAR in webhcat_config.sh
> -----------------------------------------------------------
>
> Key: HCATALOG-573
> URL: https://issues.apache.org/jira/browse/HCATALOG-573
> Project: HCatalog
> Issue Type: Bug
> Components: webhcat-svr
> Reporter: Thejas M Nair
> Assignee: Thejas M Nair
> Fix For: 0.5
>
> Attachments: HCATALOG-573.1.patch, HCATALOG-573.2.patch
>
>
> In webhcat_config.sh, WEBHCAT_JAR variable is set to webhcat jar name ,
> which includes the version number.
> This means that the code has to change each time a new release (with new
> version no) happens.
> It should instead use a regex to match jar of current version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
