[ https://issues.apache.org/jira/browse/HDFS-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12729646#action_12729646 ]
Hadoop QA commented on HDFS-462: -------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12413051/HDFS-462.patch against trunk revision 792881. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-vesta.apache.org/15/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-vesta.apache.org/15/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-vesta.apache.org/15/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-vesta.apache.org/15/console This message is automatically generated. > Unit tests not working under Windows > ------------------------------------ > > Key: HDFS-462 > URL: https://issues.apache.org/jira/browse/HDFS-462 > Project: Hadoop HDFS > Issue Type: Bug > Components: name-node, test > Affects Versions: 0.21.0 > Environment: Windows > Reporter: Luca Telloli > Assignee: Jakob Homan > Fix For: 0.21.0 > > Attachments: HDFS-462.patch, TEST-org.apache.hadoop.hdfs.TestHdfs.txt > > > Unit tests are failing on windows due to a problem with rename. > The failing code is around line 520 in FSImage.java: > {noformat} > assert curDir.exists() : "Current directory must exist."; > assert !prevDir.exists() : "prvious directory must not exist."; > assert !tmpDir.exists() : "prvious.tmp directory must not exist."; > // rename current to tmp > rename(curDir, tmpDir); > // save new image > if (!curDir.mkdir()) > throw new IOException("Cannot create directory " + curDir); > {noformat} > and seems related to some open file or directory -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.