[ https://issues.apache.org/jira/browse/HDFS-529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Shvachko updated HDFS-529: ------------------------------------- Attachment: BlocksMap.patch By replacing type {{Block}} with {{BlockInfo}} for local variables and methods the patch avoids unnecessary searches. > More redundant block searches in BlockManager. > ---------------------------------------------- > > Key: HDFS-529 > URL: https://issues.apache.org/jira/browse/HDFS-529 > Project: Hadoop HDFS > Issue Type: Improvement > Components: name-node > Affects Versions: 0.21.0 > Reporter: Konstantin Shvachko > Assignee: Konstantin Shvachko > Fix For: 0.21.0 > > Attachments: BlocksMap.patch > > > Found more redundant searches in {{BlockManager.addStoredBLock()}} and > {{BlockManager.getNodes(Block)}}. > The pattern here is that we first call {{BlocksMap.numNodes(Block)}} in order > to determine the size of the array of data-nodes. This is one search in > {{blocksMap}}. Then we call {{BlocksMap.nodeIterator(Block)}}, which also > performs a search. This is all not necessary because we already have the > block in the form of BlockInfo from {{blocksMap}} and do not need to search > for it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.