[ https://issues.apache.org/jira/browse/HDFS-529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739882#action_12739882 ]
Konstantin Shvachko commented on HDFS-529: ------------------------------------------ Both run-test-hdfs and test-patch pass: {code} [exec] There appear to be 150 release audit warnings before the patch and 150 release audit warnings after applying the patch. [exec] -1 overall. [exec] +1 @author. The patch does not contain any @author tags. [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] ====================================================================== [exec] ====================================================================== [exec] Finished build. [exec] ====================================================================== [exec] ====================================================================== {code} > More redundant block searches in BlockManager. > ---------------------------------------------- > > Key: HDFS-529 > URL: https://issues.apache.org/jira/browse/HDFS-529 > Project: Hadoop HDFS > Issue Type: Improvement > Components: name-node > Affects Versions: 0.21.0 > Reporter: Konstantin Shvachko > Assignee: Konstantin Shvachko > Fix For: 0.21.0 > > Attachments: BlocksMap.patch, BlocksMap.patch > > > Found more redundant searches in {{BlockManager.addStoredBLock()}} and > {{BlockManager.getNodes(Block)}}. > The pattern here is that we first call {{BlocksMap.numNodes(Block)}} in order > to determine the size of the array of data-nodes. This is one search in > {{blocksMap}}. Then we call {{BlocksMap.nodeIterator(Block)}}, which also > performs a search. This is all not necessary because we already have the > block in the form of BlockInfo from {{blocksMap}} and do not need to search > for it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.