[
https://issues.apache.org/jira/browse/HDFS-1001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862370#action_12862370
]
Eli Collins commented on HDFS-1001:
-----------------------------------
+1 Nice change.
Nits:
* in DataNode "DataNode always expects" should read "always checks" since the
response is optional.
* Would rename readCasually to something like readBytesCheckEOS
* In DataXceiver "from client" should read "from the client"
> DataXceiver and BlockReader disagree on when to send/recv CHECKSUM_OK
> ---------------------------------------------------------------------
>
> Key: HDFS-1001
> URL: https://issues.apache.org/jira/browse/HDFS-1001
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: bc Wong
> Assignee: bc Wong
> Attachments: HDFS-1001-2.patch, HDFS-1001-3.patch, HDFS-1001-3.patch,
> HDFS-1001-rebased.patch, HDFS-1001.patch, HDFS-1001.patch.1
>
>
> Running the TestPread with additional debug statements reveals that the
> BlockReader sends CHECKSUM_OK when the DataXceiver doesn't expect it.
> Currently it doesn't matter since DataXceiver closes the connection after
> each op, and CHECKSUM_OK is the last thing on the wire. But if we want to
> cache connections, they need to agree on the exchange of CHECKSUM_OK.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
