[ 
https://issues.apache.org/jira/browse/HDFS-1001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12865936#action_12865936
 ] 

Eli Collins commented on HDFS-1001:
-----------------------------------

bq. Another way to fix this bug is to make the client not send CHECKSUM_OK for 
partial block reads. However, that complicates the protocol and makes it 
unclean. 

Agree the way you currently have it is better.  Latest patch looks good to me.

> DataXceiver and BlockReader disagree on when to send/recv CHECKSUM_OK
> ---------------------------------------------------------------------
>
>                 Key: HDFS-1001
>                 URL: https://issues.apache.org/jira/browse/HDFS-1001
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: bc Wong
>            Assignee: bc Wong
>         Attachments: HDFS-1001-2.patch, HDFS-1001-3.patch, HDFS-1001-3.patch, 
> HDFS-1001-4.patch, HDFS-1001-rebased.patch, HDFS-1001.patch, HDFS-1001.patch.1
>
>
> Running the TestPread with additional debug statements reveals that the 
> BlockReader sends CHECKSUM_OK when the DataXceiver doesn't expect it. 
> Currently it doesn't matter since DataXceiver closes the connection after 
> each op, and CHECKSUM_OK is the last thing on the wire. But if we want to 
> cache connections, they need to agree on the exchange of CHECKSUM_OK.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to