[ 
https://issues.apache.org/jira/browse/HDFS-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12866691#action_12866691
 ] 

sam rash commented on HDFS-1142:
--------------------------------

Hey Todd, one question:  why does FSNameSystem.internalReleaseLease() now take 
the recovery holder as a parameter?  It's only called in 2 places 
(startFileInternal and checkLeases) and both cases use the same constant.  The 
patches you had for hdfs-142 had the constant within the function when you 
called reassignLease().  Is there a reason to move it up?  just wondering if 
you anticipate the recovery lease holder being something other than a constant 
that needs to flow from further up?  (otherwise it's just a parameter that's 
always a constant)

> Lease recovery doesn't reassign lease when triggered by append()
> ----------------------------------------------------------------
>
>                 Key: HDFS-1142
>                 URL: https://issues.apache.org/jira/browse/HDFS-1142
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.21.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Blocker
>         Attachments: hdfs-1142.txt, hdfs-1142.txt
>
>
> If a soft lease has expired and another writer calls append(), it triggers 
> lease recovery but doesn't reassign the lease to a new owner. Therefore, the 
> old writer can continue to allocate new blocks, try to steal back the lease, 
> etc. This is for the testRecoveryOnBlockBoundary case of HDFS-1139

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to