[ 
https://issues.apache.org/jira/browse/HDFS-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12868487#action_12868487
 ] 

Konstantin Shvachko commented on HDFS-1142:
-------------------------------------------

One of the tests {{testRecoveryOnBlockBoundary()}} fails because you explicitly 
call
{code}
stm.hflush();
fail("Sync was allowed after recovery started");
{code}
The test +assumes+ that {{hflush()}} should not succeed after the recovery 
started, but this assumption is incorrect.
Btw, the test falls into infinite loop after that, because you infinitely 
trying to append to a file when the file system is already closed.
The other two tests run fine with current code.

> Lease recovery doesn't reassign lease when triggered by append()
> ----------------------------------------------------------------
>
>                 Key: HDFS-1142
>                 URL: https://issues.apache.org/jira/browse/HDFS-1142
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.21.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Blocker
>         Attachments: hdfs-1142.txt, hdfs-1142.txt
>
>
> If a soft lease has expired and another writer calls append(), it triggers 
> lease recovery but doesn't reassign the lease to a new owner. Therefore, the 
> old writer can continue to allocate new blocks, try to steal back the lease, 
> etc. This is for the testRecoveryOnBlockBoundary case of HDFS-1139

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to