[
https://issues.apache.org/jira/browse/HDFS-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231023#comment-14231023
]
Kai Zheng commented on HDFS-7349:
---------------------------------
Hi Vinay,
The patch looks great even in the initial stage. My comments are:
1. Looks like more tasks are done than said in the issue description. Should we
change it to reflect that?
2. Regarding the new command usage:
* convertToEC may need a schema parameter;
* help and usage may be redundant;
* could we use "ec" instead of "erasure" for the command? Single word 'erasure'
might not be complete to mean 'erasure coding'.
* what does async mean? In my understanding the two operations could/should
always be done in async manner as they're very time consuming.
3. We would have a default EC schema that's built in the system but can be
overridden by via configuration for user's convenience. When convertToEC with
no schema given, the default schema will be employed. Makes sense?
4. Minor, in ClientNamenodeProtocolServerSideTranslatorPB.java, looks like too
many import lines are affected.
5. Minor, to be consistent among us using EC as the common prefix, could we
rename some constructs like ErasureCli like to be ECCli? Thanks.
6. Should we upgrade any RPC version for the protocol extension?
Please help clarify if I misunderstood any point. Thanks.
> Support DFS command for the EC encoding
> ---------------------------------------
>
> Key: HDFS-7349
> URL: https://issues.apache.org/jira/browse/HDFS-7349
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Vinayakumar B
> Assignee: Vinayakumar B
> Attachments: HDFS-7349-001.patch
>
>
> Support implementation of the following commands
> *hdfs dfs -convertToEC <path>*
> <path>: Converts all blocks under this path to EC form (if not already in
> EC form, and if can be coded).
> *hdfs dfs -convertToRep <path>*
> <path>: Converts all blocks under this path to be replicated form.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
