[
https://issues.apache.org/jira/browse/HDFS-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232602#comment-14232602
]
Vinayakumar B commented on HDFS-7349:
-------------------------------------
bq. 1. Looks like more tasks are done than said in the issue description.
Should we change it to reflect that?
Yes, will update it. As initial description was from the design, which included
only these two commands.
bq. convertToEC may need a schema parameter;
According to design, if there are multiple schema implementations available,
these to be configured in ec zones, not for the individual convertions. Not for
individual convertions. Am I right?
bq. help and usage may be redundant;
These are actually different. {{-help}} gives detailed description, where as
{{-usage}} gives the short form of syntax. And these are available in
{{FsShell}} as well.
bq, could we use "ec" instead of "erasure" for the command? Single word
'erasure' might not be complete to mean 'erasure coding'.
yes, agreed.
bq. what does async mean? In my understanding the two operations could/should
always be done in async manner as they're very time consuming.
I feel, even though its time consuming, command should ensure successful
encoding which could be done by waiting to complete the conversion. What you
think?
bq. We would have a default EC schema that's built in the system but can be
overridden by via configuration for user's convenience. When convertToEC with
no schema given, the default schema will be employed. Makes sense?
Ans same as #2. Agree?
bq. . Minor, in ClientNamenodeProtocolServerSideTranslatorPB.java, looks like
too many import lines are affected.
Oh!, Yes, will take care in next patch.
bq. Minor, to be consistent among us using EC as the common prefix, could we
rename some constructs like ErasureCli like to be ECCli? Thanks.
Sure.
bq. Should we upgrade any RPC version for the protocol extension?
You are talking about {{ClientProtocol#versionID}} ?
{code} * 69L is the last version id when this class was used for protocols
* serialization. DO not update this version any further. {code}
As per above comment, no further changes required. Now we use Protobuf for
serialization which provides better wire compatibility.
> Support DFS command for the EC encoding
> ---------------------------------------
>
> Key: HDFS-7349
> URL: https://issues.apache.org/jira/browse/HDFS-7349
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Vinayakumar B
> Assignee: Vinayakumar B
> Attachments: HDFS-7349-001.patch
>
>
> Support implementation of the following commands
> *hdfs dfs -convertToEC <path>*
> <path>: Converts all blocks under this path to EC form (if not already in
> EC form, and if can be coded).
> *hdfs dfs -convertToRep <path>*
> <path>: Converts all blocks under this path to be replicated form.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
