[
https://issues.apache.org/jira/browse/HDFS-7498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14239896#comment-14239896
]
Jing Zhao commented on HDFS-7498:
---------------------------------
Thanks for the review, Haohui!
bq. Is it accidental?
No. After we have INode feature we no longer have inode replacement logic. Thus
we do not need to reset the parent node in the INodesInPath here.
> Simplify the logic in INodesInPath
> ----------------------------------
>
> Key: HDFS-7498
> URL: https://issues.apache.org/jira/browse/HDFS-7498
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Attachments: HDFS-7498.000.patch
>
>
> Currently we have relatively complicated logic in INodesInPath:
> 1) It can contain null elements in its INode array, and in
> {{mkdirRecursively}} these null INodes are replaced with new directories.
> 2) Operations like rename may also replace the inode in its INode array
> 3) {{getINodes}} requires trimming inodes array if the INodesInPath is
> derived from a dot-snapshot path
> 4) A lot of methods directly use/manipulate its INode array
> We aim to simplify the logic of INodesInPath in this jira. Specifically, we
> can
> make INodesInPath an immutable data structure and move the inode trimming
> logic to path resolving.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
