[ https://issues.apache.org/jira/browse/HDFS-7498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14240900#comment-14240900 ]
Hudson commented on HDFS-7498: ------------------------------ FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #36 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/36/]) HDFS-7498. Simplify the logic in INodesInPath. Contributed by Jing Zhao. (jing9: rev 5776a41da08af653206bb94d7c76c9c4dcce059a) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirRenameOp.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestSnapshotPathINodes.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSPermissionChecker.java * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Path.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodesInPath.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EncryptionZoneManager.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirMkdirOp.java > Simplify the logic in INodesInPath > ---------------------------------- > > Key: HDFS-7498 > URL: https://issues.apache.org/jira/browse/HDFS-7498 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode > Reporter: Jing Zhao > Assignee: Jing Zhao > Fix For: 2.7.0 > > Attachments: HDFS-7498.000.patch > > > Currently we have relatively complicated logic in INodesInPath: > 1) It can contain null elements in its INode array, and in > {{mkdirRecursively}} these null INodes are replaced with new directories. > 2) Operations like rename may also replace the inode in its INode array > 3) {{getINodes}} requires trimming inodes array if the INodesInPath is > derived from a dot-snapshot path > 4) A lot of methods directly use/manipulate its INode array > We aim to simplify the logic of INodesInPath in this jira. Specifically, we > can > make INodesInPath an immutable data structure and move the inode trimming > logic to path resolving. -- This message was sent by Atlassian JIRA (v6.3.4#6332)