[
https://issues.apache.org/jira/browse/HDFS-7484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256528#comment-14256528
]
Hadoop QA commented on HDFS-7484:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12688738/HDFS-7484.009.patch
against trunk revision 2cf90a2.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 4 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/9114//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/9114//artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/9114//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9114//console
This message is automatically generated.
> Make FSDirectory#addINode take existing INodes as its parameter
> ---------------------------------------------------------------
>
> Key: HDFS-7484
> URL: https://issues.apache.org/jira/browse/HDFS-7484
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Haohui Mai
> Assignee: Jing Zhao
> Attachments: HDFS-7484.000.patch, HDFS-7484.001.patch,
> HDFS-7484.002.patch, HDFS-7484.003.patch, HDFS-7484.004.patch,
> HDFS-7484.005.patch, HDFS-7484.006.patch, HDFS-7484.007.patch,
> HDFS-7484.008.patch, HDFS-7484.009.patch
>
>
> Currently {{FSDirectory#addLastINode}} takes an INodesInPath instance, which
> uses null elements to indicate INodes to create, as its parameter. This logic
> makes the logic of {{mkdir}} complicated. It will be better to let
> {{addLastINode}}'s INodesInPath parameter only contain existing INodes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
