[
https://issues.apache.org/jira/browse/HDFS-7484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256685#comment-14256685
]
Haohui Mai commented on HDFS-7484:
----------------------------------
Thanks for working on this. The patch simplifies the code of {{mkdirs()}} and
{{rename()}}, making them much easier to follow. +1.
> Make FSDirectory#addINode take existing INodes as its parameter
> ---------------------------------------------------------------
>
> Key: HDFS-7484
> URL: https://issues.apache.org/jira/browse/HDFS-7484
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Haohui Mai
> Assignee: Jing Zhao
> Attachments: HDFS-7484.000.patch, HDFS-7484.001.patch,
> HDFS-7484.002.patch, HDFS-7484.003.patch, HDFS-7484.004.patch,
> HDFS-7484.005.patch, HDFS-7484.006.patch, HDFS-7484.007.patch,
> HDFS-7484.008.patch, HDFS-7484.009.patch
>
>
> Currently {{FSDirectory#addLastINode}} takes an INodesInPath instance, which
> uses null elements to indicate INodes to create, as its parameter. This logic
> makes the logic of {{mkdir}} complicated. It will be better to let
> {{addLastINode}}'s INodesInPath parameter only contain existing INodes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
