[
https://issues.apache.org/jira/browse/HDFS-7411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313386#comment-14313386
]
Andrew Wang commented on HDFS-7411:
-----------------------------------
Re: node-to-block translation, do any of my proposed schemes meet your
criteria? I think I laid out concerns from the perspective of the admin
correctly, with pause time being the most important one. I'll also note by that
metric, fixing the bug of counting live nodes will quite severely affect pause
time.
Re: proven to be working, is there additional testing that you will find
satisfactory? This change passes the existing decommission unit tests, as well
as adding a fair bit more. I think it's quite rare to preserve old code that's
functionally the same behind a config. I actually can't think of an example
from the last two years.
As usual, I'll sign myself up to fix any issues that surface, so there's no
worry about ongoing maintenance.
> Refactor and improve decommissioning logic into DecommissionManager
> -------------------------------------------------------------------
>
> Key: HDFS-7411
> URL: https://issues.apache.org/jira/browse/HDFS-7411
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 2.5.1
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Attachments: hdfs-7411.001.patch, hdfs-7411.002.patch,
> hdfs-7411.003.patch, hdfs-7411.004.patch, hdfs-7411.005.patch,
> hdfs-7411.006.patch, hdfs-7411.007.patch, hdfs-7411.008.patch,
> hdfs-7411.009.patch, hdfs-7411.010.patch
>
>
> Would be nice to split out decommission logic from DatanodeManager to
> DecommissionManager.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
