[
https://issues.apache.org/jira/browse/HDFS-7411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14315141#comment-14315141
]
Tsz Wo Nicholas Sze commented on HDFS-7411:
-------------------------------------------
> It does not seem the case to me since no one ever commented on the
> incompatible change earlier.
I am actually quite surpurised that this was an incompatible change in many
ways:
- From the JIRA summary, it starts with "Refactor and improve" which does not
sound like incompatible.
- From the earlier comments such as "... but this scheme preserves backwards
compatibility." and "... The idea here was to be compatible with the old config
option, ...". It does seem that the patch is compatible.
- Before I said that ["dfs.namenode.decommission.nodes.per.interval should be
deprecated
first"|https://issues.apache.org/jira/browse/HDFS-7411?focusedCommentId=14294224&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14294224].
No other contributors/reviewers mentioned that the patch removed a public
conf so that it was incompatible.
- The JIRA was not marked as an "Incompatible change".
> Refactor and improve decommissioning logic into DecommissionManager
> -------------------------------------------------------------------
>
> Key: HDFS-7411
> URL: https://issues.apache.org/jira/browse/HDFS-7411
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 2.5.1
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Attachments: hdfs-7411.001.patch, hdfs-7411.002.patch,
> hdfs-7411.003.patch, hdfs-7411.004.patch, hdfs-7411.005.patch,
> hdfs-7411.006.patch, hdfs-7411.007.patch, hdfs-7411.008.patch,
> hdfs-7411.009.patch, hdfs-7411.010.patch
>
>
> Would be nice to split out decommission logic from DatanodeManager to
> DecommissionManager.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
