[ 
https://issues.apache.org/jira/browse/HDFS-7991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14387400#comment-14387400
 ] 

Allen Wittenauer commented on HDFS-7991:
----------------------------------------

-1

a) Take a look at  
http://wiki.apache.org/hadoop/UnixShellScriptProgrammingGuide.

b) Why are we trying to fix this at the shell level instead of at the Java 
level? 

c) HDFS_CHECKPOINT_BEFORE_STOP_NAMENODE

This should be HADOOP_HDFS_ blah, not HDFS_blah.

d) There's no way this passes shellcheck.

e) error messages are *way* too long for a single line.

f) where is the hadoop-env.sh documentation to match this new env var?



> Allow users to skip checkpoint when stopping NameNode
> -----------------------------------------------------
>
>                 Key: HDFS-7991
>                 URL: https://issues.apache.org/jira/browse/HDFS-7991
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>         Attachments: HDFS-7991.000.patch, HDFS-7991.001.patch, 
> HDFS-7991.002.patch
>
>
> This is a follow-up jira of HDFS-6353. HDFS-6353 adds the functionality to 
> check if saving namespace is necessary before stopping namenode. As [~kihwal] 
> pointed out in this 
> [comment|https://issues.apache.org/jira/browse/HDFS-6353?focusedCommentId=14380898&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14380898],
>  in a secured cluster this new functionality requires the user to be kinit'ed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to