[ 
https://issues.apache.org/jira/browse/HDFS-7991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14387422#comment-14387422
 ] 

Allen Wittenauer commented on HDFS-7991:
----------------------------------------

Frankly, I'm sort of leaning towards -1 on the feature itself. 

This is a very bad idea to this at the shell level where it has no way to know 
how or why things are broken.  This really feels like a "throw it over the 
fence and the let shell code sort it out" exercise.

I mean from HDFS-8003:

bq. With new changes in HDFS-7991, if the feature is on, the shell code will 
exit if the checkpoint fails and the NN will not be stopped.

You realize this isn't true, right?  There is no error checking in this patch 
or the previous one that got committed that stops the shell code.  It just 
continues plowing on through. 



> Allow users to skip checkpoint when stopping NameNode
> -----------------------------------------------------
>
>                 Key: HDFS-7991
>                 URL: https://issues.apache.org/jira/browse/HDFS-7991
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>         Attachments: HDFS-7991.000.patch, HDFS-7991.001.patch, 
> HDFS-7991.002.patch
>
>
> This is a follow-up jira of HDFS-6353. HDFS-6353 adds the functionality to 
> check if saving namespace is necessary before stopping namenode. As [~kihwal] 
> pointed out in this 
> [comment|https://issues.apache.org/jira/browse/HDFS-6353?focusedCommentId=14380898&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14380898],
>  in a secured cluster this new functionality requires the user to be kinit'ed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to