[ 
https://issues.apache.org/jira/browse/HDFS-7889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392493#comment-14392493
 ] 

Vinayakumar B commented on HDFS-7889:
-------------------------------------

bq. This is because byteArrayManager.newByteArray(cellSize) will throw 
InterruptedException. I think we don’t need to get cell buffers from 
byteArrayManager. Will fix it in new patch
IMO we should use byteArrayManager, but need to throw back the exception, 
instead of catching, whenever interruptedexception comes, catching this 
exception will void the interrupt call from user 
code.{{DFSOutputStream#createPacket}} throws back the exception as below. 
{code}    try {
      buf = byteArrayManager.newByteArray(bufferSize);
    } catch (InterruptedException ie) {
      final InterruptedIOException iioe = new InterruptedIOException(
          "seqno=" + seqno);
      iioe.initCause(ie);
      throw iioe;
    {code}

bq. clearCellBuffers(int index) not required, at least as of now.
I should have been little specific. I mean to say is, separate method not 
required. {{clearCellBuffers()}} itself could contain 
{{cellBuffers\[i\].clear()}}.


> Subclass DFSOutputStream to support writing striping layout files
> -----------------------------------------------------------------
>
>                 Key: HDFS-7889
>                 URL: https://issues.apache.org/jira/browse/HDFS-7889
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Li Bo
>            Assignee: Li Bo
>         Attachments: HDFS-7889-001.patch, HDFS-7889-002.patch, 
> HDFS-7889-003.patch, HDFS-7889-004.patch, HDFS-7889-005.patch, 
> HDFS-7889-006.patch, HDFS-7889-007.patch
>
>
> After HDFS-7888, we can subclass  {{DFSOutputStream}} to support writing 
> striping layout files. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to