[ https://issues.apache.org/jira/browse/HDFS-5574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510895#comment-14510895 ]
Hadoop QA commented on HDFS-5574: --------------------------------- \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 14m 41s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 4 new or modified test files. | | {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that end in whitespace. | | {color:red}-1{color} | javac | 7m 37s | The applied patch generated 125 additional warning messages. | | {color:green}+1{color} | javadoc | 9m 47s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 22s | The applied patch does not increase the total number of release audit warnings. | | {color:red}-1{color} | checkstyle | 3m 58s | The applied patch generated 1 additional checkstyle issues. | | {color:green}+1{color} | install | 1m 34s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 4m 44s | The patch does not introduce any new Findbugs (version 2.0.3) warnings. | | {color:red}-1{color} | common tests | 22m 51s | Tests failed in hadoop-common. | | {color:red}-1{color} | hdfs tests | 0m 31s | Tests failed in hadoop-hdfs. | | | | 66m 42s | | \\ \\ || Reason || Tests || | Failed unit tests | hadoop.security.ssl.TestReloadingX509TrustManager | | Failed build | hadoop-hdfs | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12685973/HDFS-5574.006.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / c8d7290 | | javac | https://builds.apache.org/job/PreCommit-HDFS-Build/10369/artifact/patchprocess/diffJavacWarnings.txt | | checkstyle | https://builds.apache.org/job/PreCommit-HDFS-Build/10369/artifact/patchprocess/checkstyle-result-diff.txt | | hadoop-common test log | https://builds.apache.org/job/PreCommit-HDFS-Build/10369/artifact/patchprocess/testrun_hadoop-common.txt | | hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/10369/artifact/patchprocess/testrun_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/10369/testReport/ | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/10369/console | This message was automatically generated. > Remove buffer copy in BlockReader.skip > -------------------------------------- > > Key: HDFS-5574 > URL: https://issues.apache.org/jira/browse/HDFS-5574 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: Binglin Chang > Assignee: Binglin Chang > Priority: Trivial > Attachments: HDFS-5574.006.patch, HDFS-5574.v1.patch, > HDFS-5574.v2.patch, HDFS-5574.v3.patch, HDFS-5574.v4.patch, HDFS-5574.v5.patch > > > BlockReaderLocal.skip and RemoteBlockReader.skip uses a temp buffer to read > data to this buffer, it is not necessary. -- This message was sent by Atlassian JIRA (v6.3.4#6332)