[jira] [Commented] (HDFS-5574) Remove buffer copy in BlockReader.skip

[Akira AJISAKA (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HDFS-5574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513697#comment-14513697
 ] 

Akira AJISAKA commented on HDFS-5574:
-------------------------------------

Hi [~decster], would you replace {{DFS_CLIENT_READ_SHORTCIRCUIT_KEY}} with 
{{HdfsClientConfigKeys.Read.ShortCircuit.KEY}} in TestDFSInputStream? That will 
fix the javac warning.

For checkstyle warnings, would you make {{FSInputChecker#readAndDiscard}} final 
and adding {{@return}}, {{@param}}, and {{@throws}} tags in javadoc?
{code}
<error line="222" severity="error" message="Expected an @return tag." 
source="com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck"/>
<error line="222" column="3" severity="error" message="Method 
&apos;readAndDiscard&apos; is not designed for extension - needs to be 
abstract, final or empty." 
source="com.puppycrawl.tools.checkstyle.checks.design.DesignForExtensionCheck"/>
<error line="222" column="45" severity="error" message="Parameter len should be 
final." source="com.puppycrawl.tools.checkstyle.checks.FinalParametersCheck"/>
<error line="222" column="49" severity="error" message="Expected @param tag for 
&apos;len&apos;." 
source="com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck"/>
<error line="222" column="61" severity="error" message="Expected @throws tag 
for &apos;IOException&apos;." 
source="com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck"/>
{code}

> Remove buffer copy in BlockReader.skip
> --------------------------------------
>
>                 Key: HDFS-5574
>                 URL: https://issues.apache.org/jira/browse/HDFS-5574
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>            Priority: Trivial
>         Attachments: HDFS-5574.006.patch, HDFS-5574.v1.patch, 
> HDFS-5574.v2.patch, HDFS-5574.v3.patch, HDFS-5574.v4.patch, HDFS-5574.v5.patch
>
>
> BlockReaderLocal.skip and RemoteBlockReader.skip uses a temp buffer to read 
> data to this buffer, it is not necessary. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)