[
https://issues.apache.org/jira/browse/HDFS-8305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525645#comment-14525645
]
Yongjun Zhang commented on HDFS-8305:
-------------------------------------
HI [~cmccabe],
Thanks for reporting the issue and the patch. It looks good to me, only couple
of minor comments:
* can we add a description to this jira explaining why (e.g., "This, in turn,
ensures that inotify will always be able to consider the dst field as the full
destination file name.")?
* can we add java doc to the {{void logRename(}} methods to say something like
"if the rename source is a file, the target is better to be a file too, this
will ensure that inotify will always be able to confider the dst file as the
full destination file name."?
Thanks.
> HDFS INotify: the destination field of RenameOp should always end with the
> file name
> ------------------------------------------------------------------------------------
>
> Key: HDFS-8305
> URL: https://issues.apache.org/jira/browse/HDFS-8305
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.6.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HDFS-8305.001.patch
>
>
> HDFS INotify: the destination field of RenameOp should always end with the
> file name rather than sometimes being a directory name.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
