[
https://issues.apache.org/jira/browse/HDFS-8305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527023#comment-14527023
]
Colin Patrick McCabe commented on HDFS-8305:
--------------------------------------------
bq. can we add a description to this jira explaining why (e.g., "This, in turn,
ensures that inotify will always be able to consider the dst field as the full
destination file name.")?
added
bq. can we add java doc to the void logRename( methods to say something like
"if the rename source is a file, the target is better to be a file too, this
will ensure that inotify will always be able to confider the dst file as the
full destination file name."?
ok
> HDFS INotify: the destination field of RenameOp should always end with the
> file name
> ------------------------------------------------------------------------------------
>
> Key: HDFS-8305
> URL: https://issues.apache.org/jira/browse/HDFS-8305
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.6.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HDFS-8305.001.patch
>
>
> HDFS INotify: the destination field of RenameOp should always end with the
> file name rather than sometimes being a directory name. Previously, in some
> cases when using the old rename, this was not the case. The format of
> OP_EDIT_LOG_RENAME_OLD allows moving /f to /d/f to be represented as
> RENAME(src=/f, dst=/d) or RENAME(src=/f, dst=/d/f). This change makes HDFS
> always use the latter form. This, in turn, ensures that inotify will always
> be able to consider the dst field as the full destination file name. This is
> a compatible change since we aren't removing the ability to handle the first
> form during edit log replay... we just no longer generate it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
