[
https://issues.apache.org/jira/browse/HDFS-8309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525655#comment-14525655
]
Xiaoyu Yao commented on HDFS-8309:
----------------------------------
Thanks [~steve_l] for the review. I will commit this shortly.
> Skip unit test using DataNodeTestUtils#injectDataDirFailure() on Windows
> ------------------------------------------------------------------------
>
> Key: HDFS-8309
> URL: https://issues.apache.org/jira/browse/HDFS-8309
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Affects Versions: 2.7.0
> Reporter: Xiaoyu Yao
> Assignee: Xiaoyu Yao
> Priority: Minor
> Attachments: HDFS-8309.00.patch
>
>
> As [~cnauroth] noted in HDFS-7917 below,
> DataNodeTestUtils.injectDataDirFailure() won't work for Windows as rename
> will fail due to open handles on data node dir. This ticket is opened to skip
> these tests for Windows.
> bq.Unfortunately, I just remembered that the rename isn't going to work on
> Windows. It typically doesn't allow you to rename a directory where there are
> open file handles anywhere in the sub-tree. We'd have to shutdown the
> DataNode before doing the rename and then start it up. By doing that, we'd be
> changing the meaning of the test from covering an online failure to covering
> a failure at DataNode startup, so I don't think we can make that change.
> Below are the two test cases that need to be fixed:
> # TestDataNodeVolumeFailure#testFailedVolumeBeingRemovedFromDataNode
> # TestDataNodeHotSwapVolumes.testDirectlyReloadAfterCheckDiskError
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
