[ https://issues.apache.org/jira/browse/HDFS-8309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14526074#comment-14526074 ]
Hudson commented on HDFS-8309: ------------------------------ SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2132 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2132/]) HDFS-8309. Skip unit test using DataNodeTestUtils#injectDataDirFailure() on Windows. (xyao) (xyao: rev a319771d1d9eebaf8e4165dba73383a229cb1525) * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailureReporting.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailure.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeHotSwapVolumes.java > Skip unit test using DataNodeTestUtils#injectDataDirFailure() on Windows > ------------------------------------------------------------------------ > > Key: HDFS-8309 > URL: https://issues.apache.org/jira/browse/HDFS-8309 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: test > Affects Versions: 2.7.0 > Reporter: Xiaoyu Yao > Assignee: Xiaoyu Yao > Priority: Minor > Fix For: 2.8.0 > > Attachments: HDFS-8309.00.patch > > > As [~cnauroth] noted in HDFS-7917 below, > DataNodeTestUtils.injectDataDirFailure() won't work for Windows as rename > will fail due to open handles on data node dir. This ticket is opened to skip > these tests for Windows. > bq.Unfortunately, I just remembered that the rename isn't going to work on > Windows. It typically doesn't allow you to rename a directory where there are > open file handles anywhere in the sub-tree. We'd have to shutdown the > DataNode before doing the rename and then start it up. By doing that, we'd be > changing the meaning of the test from covering an online failure to covering > a failure at DataNode startup, so I don't think we can make that change. > Below are the two test cases that need to be fixed: > # TestDataNodeVolumeFailure#testFailedVolumeBeingRemovedFromDataNode > # TestDataNodeHotSwapVolumes.testDirectlyReloadAfterCheckDiskError -- This message was sent by Atlassian JIRA (v6.3.4#6332)