[ 
https://issues.apache.org/jira/browse/HDFS-8643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14654334#comment-14654334
 ] 

Xiaoyu Yao commented on HDFS-8643:
----------------------------------

Thanks [~rakeshr] for adding this. Patch LGTM. +1

One question: Have you thought of enhancing *lsSnapshottableDir* cmd of HDFS 
CLI with additional parameter to display the snapshot name information? This 
could be done in a separate JIRA?

> Add snapshot names list to SnapshottableDirectoryStatus
> -------------------------------------------------------
>
>                 Key: HDFS-8643
>                 URL: https://issues.apache.org/jira/browse/HDFS-8643
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>         Attachments: HDFS-8643-00.patch
>
>
> The idea of this jira to enhance {{SnapshottableDirectoryStatus}} by adding 
> {{snapshotNames}} attribute into it, presently it has the {{snapshotNumber}}. 
> IMHO this would help the users to get the list of snapshot names created. 
> Also, the snapshot names can be used while renaming or deleting the snapshots.
> {code}
> org.apache.hadoop.hdfs.protocol.SnapshottableDirectoryStatus.java
>   /**
>    * @return Snapshot names for the directory.
>    */
>   public List <String> getSnapshotNames() {
>     return snapshotNames;
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to