[ https://issues.apache.org/jira/browse/HDFS-8643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659131#comment-14659131 ]
Hadoop QA commented on HDFS-8643: --------------------------------- \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 18m 51s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 1 new or modified test files. | | {color:green}+1{color} | javac | 7m 35s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 9m 41s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 24s | The applied patch does not increase the total number of release audit warnings. | | {color:red}-1{color} | checkstyle | 2m 29s | The applied patch generated 1 new checkstyle issues (total was 15, now 15). | | {color:red}-1{color} | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. | | {color:green}+1{color} | install | 1m 29s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 4m 24s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | native | 3m 1s | Pre-build of native portion | | {color:green}+1{color} | hdfs tests | 161m 55s | Tests passed in hadoop-hdfs. | | {color:green}+1{color} | hdfs tests | 0m 28s | Tests passed in hadoop-hdfs-client. | | | | 210m 54s | | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12748900/HDFS-8643-01.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / 4ab49a4 | | checkstyle | https://builds.apache.org/job/PreCommit-HDFS-Build/11910/artifact/patchprocess/diffcheckstylehadoop-hdfs-client.txt | | whitespace | https://builds.apache.org/job/PreCommit-HDFS-Build/11910/artifact/patchprocess/whitespace.txt | | hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/11910/artifact/patchprocess/testrun_hadoop-hdfs.txt | | hadoop-hdfs-client test log | https://builds.apache.org/job/PreCommit-HDFS-Build/11910/artifact/patchprocess/testrun_hadoop-hdfs-client.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/11910/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/11910/console | This message was automatically generated. > Add snapshot names list to SnapshottableDirectoryStatus > ------------------------------------------------------- > > Key: HDFS-8643 > URL: https://issues.apache.org/jira/browse/HDFS-8643 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: Rakesh R > Assignee: Rakesh R > Attachments: HDFS-8643-00.patch, HDFS-8643-01.patch > > > The idea of this jira to enhance {{SnapshottableDirectoryStatus}} by adding > {{snapshotNames}} attribute into it, presently it has the {{snapshotNumber}}. > IMHO this would help the users to get the list of snapshot names created. > Also, the snapshot names can be used while renaming or deleting the snapshots. > {code} > org.apache.hadoop.hdfs.protocol.SnapshottableDirectoryStatus.java > /** > * @return Snapshot names for the directory. > */ > public List <String> getSnapshotNames() { > return snapshotNames; > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)