[ 
https://issues.apache.org/jira/browse/HDFS-8846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14700361#comment-14700361
 ] 

Colin Patrick McCabe commented on HDFS-8846:
--------------------------------------------

Hi [~zhz],

It seems that you left out the binary changes:
{code}
diff --git 
a/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/hadoop-252-dfs-dir.tgz 
b/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/hadoop-252-dfs-dir.tgz
new file mode 100644
index 0000000..2aaab18
Binary files /dev/null and 
b/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/hadoop-252-dfs-dir.tgz 
differ
{code}

You should create the patch with {{\-\-binary}} so that these are included

> Create edit log files with old layout version for upgrade testing
> -----------------------------------------------------------------
>
>                 Key: HDFS-8846
>                 URL: https://issues.apache.org/jira/browse/HDFS-8846
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 2.7.1
>            Reporter: Zhe Zhang
>            Assignee: Zhe Zhang
>         Attachments: HDFS-8846.00.patch
>
>
> Per discussion under HDFS-8480, we should create some edit log files with old 
> layout version, to test whether they can be correctly handled in upgrades.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to