[ https://issues.apache.org/jira/browse/HDFS-8846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14707164#comment-14707164 ]
Colin Patrick McCabe commented on HDFS-8846: -------------------------------------------- Looks good overall! Can we test reading a few different events rather than just the CreateEvent? And perhaps also test reading by transaction ID. (i.e. if we poll a transaction ID that's too high, we get nothing... if we look for one that exists in the old edit logs, we start right there). +1 once that's addressed > Create edit log files with old layout version for upgrade testing > ----------------------------------------------------------------- > > Key: HDFS-8846 > URL: https://issues.apache.org/jira/browse/HDFS-8846 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Affects Versions: 2.7.1 > Reporter: Zhe Zhang > Assignee: Zhe Zhang > Attachments: HDFS-8846.00.patch, HDFS-8846.01.patch, > HDFS-8846.02.patch > > > Per discussion under HDFS-8480, we should create some edit log files with old > layout version, to test whether they can be correctly handled in upgrades. -- This message was sent by Atlassian JIRA (v6.3.4#6332)