[ https://issues.apache.org/jira/browse/HDFS-8964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14718390#comment-14718390 ]
Hadoop QA commented on HDFS-8964: --------------------------------- \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 17m 53s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 1 new or modified test files. | | {color:green}+1{color} | javac | 7m 52s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 10m 7s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 23s | The applied patch does not increase the total number of release audit warnings. | | {color:red}-1{color} | checkstyle | 1m 22s | The applied patch generated 2 new checkstyle issues (total was 162, now 162). | | {color:red}-1{color} | whitespace | 0m 0s | The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. | | {color:green}+1{color} | install | 1m 31s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 35s | The patch built with eclipse:eclipse. | | {color:red}-1{color} | findbugs | 2m 37s | The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | native | 3m 21s | Pre-build of native portion | | {color:red}-1{color} | hdfs tests | 189m 35s | Tests failed in hadoop-hdfs. | | | | 235m 24s | | \\ \\ || Reason || Tests || | FindBugs | module:hadoop-hdfs | | Failed unit tests | hadoop.cli.TestHDFSCLI | | | hadoop.hdfs.qjournal.server.TestJournal | | | hadoop.hdfs.server.namenode.TestFSNamesystem | | | hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes | | | hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA | | | hadoop.hdfs.server.namenode.TestFileTruncate | | | hadoop.hdfs.server.namenode.TestFileJournalManager | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12752950/HDFS-8964.01.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / e166c03 | | checkstyle | https://builds.apache.org/job/PreCommit-HDFS-Build/12193/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt | | whitespace | https://builds.apache.org/job/PreCommit-HDFS-Build/12193/artifact/patchprocess/whitespace.txt | | Findbugs warnings | https://builds.apache.org/job/PreCommit-HDFS-Build/12193/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html | | hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/12193/artifact/patchprocess/testrun_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/12193/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/12193/console | This message was automatically generated. > Provide max TxId when validating in-progress edit log files > ----------------------------------------------------------- > > Key: HDFS-8964 > URL: https://issues.apache.org/jira/browse/HDFS-8964 > Project: Hadoop HDFS > Issue Type: Bug > Components: journal-node, namenode > Affects Versions: 2.7.1 > Reporter: Zhe Zhang > Assignee: Zhe Zhang > Attachments: HDFS-8964.00.patch, HDFS-8964.01.patch > > > NN/JN validates in-progress edit log files in multiple scenarios, via > {{EditLogFile#validateLog}}. The method scans through the edit log file to > find the last transaction ID. > However, an in-progress edit log file could be actively written to, which > creates a race condition and causes incorrect data to be read (and later we > attempt to interpret the data as ops). > Currently {{validateLog}} is used in 3 places: > # NN {{getEditsFromTxid}} > # JN {{getEditLogManifest}} > # NN/JN {{recoverUnfinalizedSegments}} > In the first two scenarios we should provide a maximum TxId to validate in > the in-progress file. The 3rd scenario won't cause a race condition because > only non-current in-progress edit log files are validated. > {{validateLog}} is actually only used with in-progress files, and could use a > better name and Javadoc. -- This message was sent by Atlassian JIRA (v6.3.4#6332)