[ https://issues.apache.org/jira/browse/HDFS-8964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725230#comment-14725230 ]
Hadoop QA commented on HDFS-8964: --------------------------------- \\ \\ | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 18m 20s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 4 new or modified test files. | | {color:green}+1{color} | javac | 7m 45s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 9m 57s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 24s | The applied patch does not increase the total number of release audit warnings. | | {color:green}+1{color} | checkstyle | 1m 39s | There were no new checkstyle issues. | | {color:green}+1{color} | whitespace | 0m 1s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | install | 1m 26s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 3m 14s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | native | 3m 9s | Pre-build of native portion | | {color:green}+1{color} | hdfs tests | 162m 45s | Tests passed in hadoop-hdfs. | | {color:green}+1{color} | hdfs tests | 3m 57s | Tests passed in bkjournal. | | | | 213m 15s | | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12753479/HDFS-8964.04.patch | | Optional Tests | javac unit findbugs checkstyle javadoc | | git revision | trunk / 7ad3556 | | hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/12227/artifact/patchprocess/testrun_hadoop-hdfs.txt | | bkjournal test log | https://builds.apache.org/job/PreCommit-HDFS-Build/12227/artifact/patchprocess/testrun_bkjournal.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/12227/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/12227/console | This message was automatically generated. > Provide max TxId when validating in-progress edit log files > ----------------------------------------------------------- > > Key: HDFS-8964 > URL: https://issues.apache.org/jira/browse/HDFS-8964 > Project: Hadoop HDFS > Issue Type: Bug > Components: journal-node, namenode > Affects Versions: 2.7.1 > Reporter: Zhe Zhang > Assignee: Zhe Zhang > Attachments: HDFS-8964.00.patch, HDFS-8964.01.patch, > HDFS-8964.02.patch, HDFS-8964.03.patch, HDFS-8964.04.patch > > > NN/JN validates in-progress edit log files in multiple scenarios, via > {{EditLogFile#validateLog}}. The method scans through the edit log file to > find the last transaction ID. > However, an in-progress edit log file could be actively written to, which > creates a race condition and causes incorrect data to be read (and later we > attempt to interpret the data as ops). > Currently {{validateLog}} is used in 3 places: > # NN {{getEditsFromTxid}} > # JN {{getEditLogManifest}} > # NN/JN {{recoverUnfinalizedSegments}} > In the first two scenarios we should provide a maximum TxId to validate in > the in-progress file. The 3rd scenario won't cause a race condition because > only non-current in-progress edit log files are validated. > {{validateLog}} is actually only used with in-progress files, and could use a > better name and Javadoc. -- This message was sent by Atlassian JIRA (v6.3.4#6332)