[ https://issues.apache.org/jira/browse/HDFS-8984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14729488#comment-14729488 ]
Haohui Mai commented on HDFS-8984: ---------------------------------- Thanks for the reviews. Speaking of the race conditions, this patch only moves the methods from FSNameSystem to BlockManager. There're no changes in terms of locking, callers / callees relationships, etc. Therefore I think the risk of introducing new race conditions is really low. But I definitely agree that some analysis on synchronization in the near future would definitely help. > Move replication queues related methods in FSNamesystem to BlockManager > ----------------------------------------------------------------------- > > Key: HDFS-8984 > URL: https://issues.apache.org/jira/browse/HDFS-8984 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Haohui Mai > Assignee: Haohui Mai > Attachments: HDFS-8984.000.patch, HDFS-8984.001.patch, > HDFS-8984.002.patch, HDFS-8984.003.patch, HDFS-8984.004.patch > > > Currently {{FSNamesystem}} controls whether replication queue should be > populated based on whether the NN is in safe mode or whether it is an active > NN. > Replication is a concept on the block management layer. It is more natural to > place the functionality in the {{BlockManager}} class. > This jira proposes to move the these methods to the {{BlockManager}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)