[ https://issues.apache.org/jira/browse/HDFS-8984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14730035#comment-14730035 ]
Jing Zhao commented on HDFS-8984: --------------------------------- The 04 patch looks good to me. One nit is that the change in NameNode.java is unnecessary. You can remove it when you commit the patch. +1 > Move replication queues related methods in FSNamesystem to BlockManager > ----------------------------------------------------------------------- > > Key: HDFS-8984 > URL: https://issues.apache.org/jira/browse/HDFS-8984 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Haohui Mai > Assignee: Haohui Mai > Attachments: HDFS-8984.000.patch, HDFS-8984.001.patch, > HDFS-8984.002.patch, HDFS-8984.003.patch, HDFS-8984.004.patch > > > Currently {{FSNamesystem}} controls whether replication queue should be > populated based on whether the NN is in safe mode or whether it is an active > NN. > Replication is a concept on the block management layer. It is more natural to > place the functionality in the {{BlockManager}} class. > This jira proposes to move the these methods to the {{BlockManager}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)