[ https://issues.apache.org/jira/browse/HDFS-9040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934073#comment-14934073 ]
Zhe Zhang commented on HDFS-9040: --------------------------------- Thanks Jing for the updated patch. bq. The data streamer does not call getFollowingBlock until its data queue is no longer empty. Right I missed the below logic: {code} while ((!shouldStop() && dataQueue.size() == 0 && (stage != BlockConstructionStage.DATA_STREAMING || stage == BlockConstructionStage.DATA_STREAMING && now - lastPacket < halfSocketTimeout)) || doSleep ) { {code} +1 on the patch. Thanks for the work! > Erasure coding: Refactor DFSStripedOutputStream (Move Namenode RPC Requests > to Coordinator) > ------------------------------------------------------------------------------------------- > > Key: HDFS-9040 > URL: https://issues.apache.org/jira/browse/HDFS-9040 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Walter Su > Assignee: Jing Zhao > Attachments: HDFS-9040-HDFS-7285.002.patch, > HDFS-9040-HDFS-7285.003.patch, HDFS-9040-HDFS-7285.004.patch, > HDFS-9040-HDFS-7285.005.patch, HDFS-9040-HDFS-7285.005.patch, > HDFS-9040-HDFS-7285.006.patch, HDFS-9040-HDFS-7285.007.patch, > HDFS-9040.00.patch, HDFS-9040.001.wip.patch, HDFS-9040.02.bgstreamer.patch > > > The general idea is to simplify error handling logic. > -Proposal 1:- > -A BlockGroupDataStreamer to communicate with NN to allocate/update block, > and StripedDataStreamer s only have to stream blocks to DNs.- > Proposal 2: > See below the > [comment|https://issues.apache.org/jira/browse/HDFS-9040?focusedCommentId=14741388&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14741388] > from [~jingzhao]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)