[
https://issues.apache.org/jira/browse/HDFS-9040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14905302#comment-14905302
]
Jing Zhao commented on HDFS-9040:
---------------------------------
Thanks for the review, [~walter.k.su]!
bq. It's not good enough approach. socketTimeout is 6s by default. Here you
wait at most 4s.
The socket timeout is 60s by default.
bq. I think we should notify every dataQueues to wake up streamers after
markExternalErrorOnStreamers(), so every streamer has 4s.
Actually this has been done inside of {{markExternalErrorOnStreamers}}, in
{{StripedDataStreamer#setExternalError}}.
bq. And it would be better if streamers start sending heartbeat packet in the
middle of waiting other streamers, but it's too hard.
Yeah, my original plan is also this but that requires too many code change.
I will upload a new patch to address all your other comments.
> Erasure coding: Refactor DFSStripedOutputStream (Move Namenode RPC Requests
> to Coordinator)
> -------------------------------------------------------------------------------------------
>
> Key: HDFS-9040
> URL: https://issues.apache.org/jira/browse/HDFS-9040
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Walter Su
> Assignee: Jing Zhao
> Attachments: HDFS-9040-HDFS-7285.002.patch,
> HDFS-9040-HDFS-7285.003.patch, HDFS-9040-HDFS-7285.004.patch,
> HDFS-9040.00.patch, HDFS-9040.001.wip.patch, HDFS-9040.02.bgstreamer.patch
>
>
> The general idea is to simplify error handling logic.
> -Proposal 1:-
> -A BlockGroupDataStreamer to communicate with NN to allocate/update block,
> and StripedDataStreamer s only have to stream blocks to DNs.-
> Proposal 2:
> See below the
> [comment|https://issues.apache.org/jira/browse/HDFS-9040?focusedCommentId=14741388&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14741388]
> from [~jingzhao].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
