[ 
https://issues.apache.org/jira/browse/HDFS-9223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14956389#comment-14956389
 ] 

Tsz Wo Nicholas Sze commented on HDFS-9223:
-------------------------------------------

Still need to change getCapacityUsedPercent.

+1 after it is addressed.

> Code cleanup for DatanodeDescriptor and HeartbeatManager
> --------------------------------------------------------
>
>                 Key: HDFS-9223
>                 URL: https://issues.apache.org/jira/browse/HDFS-9223
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>            Priority: Minor
>         Attachments: HDFS-9223.000.patch, HDFS-9223.001.patch, 
> HDFS-9223.002.patch
>
>
> Some code cleanup for {{DatanodeDescriptor}} and {{HeartbeatManager}}. The 
> changes include:
> # Change {{DataDescriptor#isAlive}} and {{DatanodeDescriptor#needKeyUpdate}} 
> from public to private
> # Use EnumMap for {{HeartbeatManager#storageTypeStatesMap}}
> # Move the {{isInStartupSafeMode}} out of the namesystem lock in 
> {{heartbeatCheck}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to