[ https://issues.apache.org/jira/browse/HDFS-9223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14957471#comment-14957471 ]
Hadoop QA commented on HDFS-9223: --------------------------------- \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:red}-1{color} | pre-patch | 16m 32s | Findbugs (version ) appears to be broken on trunk. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 4 new or modified test files. | | {color:green}+1{color} | javac | 8m 1s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 10m 42s | There were no new javadoc warning messages. | | {color:red}-1{color} | release audit | 0m 23s | The applied patch generated 1 release audit warnings. | | {color:green}+1{color} | checkstyle | 0m 47s | There were no new checkstyle issues. | | {color:red}-1{color} | whitespace | 0m 2s | The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. | | {color:green}+1{color} | install | 1m 39s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with eclipse:eclipse. | | {color:red}-1{color} | findbugs | 0m 28s | Post-patch findbugs hadoop-hdfs-project/hadoop-hdfs compilation is broken. | | {color:green}+1{color} | findbugs | 0m 28s | The patch does not introduce any new Findbugs (version ) warnings. | | {color:red}-1{color} | native | 0m 26s | Failed to build the native portion of hadoop-common prior to running the unit tests in hadoop-hdfs-project/hadoop-hdfs | | | | 39m 37s | | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12766595/HDFS-9223.003.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / 0d77e85 | | Release Audit | https://builds.apache.org/job/PreCommit-HDFS-Build/12982/artifact/patchprocess/patchReleaseAuditProblems.txt | | whitespace | https://builds.apache.org/job/PreCommit-HDFS-Build/12982/artifact/patchprocess/whitespace.txt | | Java | 1.7.0_55 | | uname | Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/12982/console | This message was automatically generated. > Code cleanup for DatanodeDescriptor and HeartbeatManager > -------------------------------------------------------- > > Key: HDFS-9223 > URL: https://issues.apache.org/jira/browse/HDFS-9223 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Reporter: Jing Zhao > Assignee: Jing Zhao > Priority: Minor > Attachments: HDFS-9223.000.patch, HDFS-9223.001.patch, > HDFS-9223.002.patch, HDFS-9223.003.patch > > > Some code cleanup for {{DatanodeDescriptor}} and {{HeartbeatManager}}. The > changes include: > # Change {{DataDescriptor#isAlive}} and {{DatanodeDescriptor#needKeyUpdate}} > from public to private > # Use EnumMap for {{HeartbeatManager#storageTypeStatesMap}} > # Move the {{isInStartupSafeMode}} out of the namesystem lock in > {{heartbeatCheck}} -- This message was sent by Atlassian JIRA (v6.3.4#6332)