[ https://issues.apache.org/jira/browse/HDFS-9157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14957152#comment-14957152 ]
nijel commented on HDFS-9157: ----------------------------- bq.-1 hdfs tests The test fails are un related to patch. please review > [OEV and OIV] : Unnecessary parsing for mandatory arguements if "-h" option > is specified as the only option > ----------------------------------------------------------------------------------------------------------- > > Key: HDFS-9157 > URL: https://issues.apache.org/jira/browse/HDFS-9157 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: nijel > Assignee: nijel > Attachments: HDFS-9157_1.patch, HDFS-9157_2.patch, HDFS-9157_3.patch, > HDFS-9157_4.patch, HDFS-9157_5.patch, HDFS-9157_6.patch > > > In both tools, if "-h" is specified as the only option, it throws error as > input and output not specified. > {noformat} > master:/home/nijel/hadoop-3.0.0-SNAPSHOT/bin # ./hdfs oev -h > Error parsing command-line options: Missing required options: o, i > Usage: bin/hdfs oev [OPTIONS] -i INPUT_FILE -o OUTPUT_FILE > {noformat} > In code the parsing is happening before the "-h" option is verified > Can add code to return after initial check. > {code} > if (argv.length == 1 && argv[1] == "-h") { > printHelp(); > return 0; > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)