[ 
https://issues.apache.org/jira/browse/HDFS-9157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14958805#comment-14958805
 ] 

Hudson commented on HDFS-9157:
------------------------------

FAILURE: Integrated in Hadoop-trunk-Commit #8643 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/8643/])
HDFS-9157. [OEV and OIV] : Unnecessary parsing for mandatory arguements 
(vinayakumarb: rev 08f5de1ef55f637b3bbde0ace28b42f155e285a1)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/TestOfflineEditsViewer.java
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/OfflineEditsViewer.java
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java
* 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java


> [OEV and OIV] : Unnecessary parsing for mandatory arguements if "-h" option 
> is specified as the only option
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-9157
>                 URL: https://issues.apache.org/jira/browse/HDFS-9157
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: nijel
>            Assignee: nijel
>             Fix For: 2.8.0
>
>         Attachments: HDFS-9157_1.patch, HDFS-9157_2.patch, HDFS-9157_3.patch, 
> HDFS-9157_4.patch, HDFS-9157_5.patch, HDFS-9157_6.patch
>
>
> In both tools, if "-h" is specified as the only option, it throws error as 
> input and output not specified.
> {noformat}
> master:/home/nijel/hadoop-3.0.0-SNAPSHOT/bin # ./hdfs oev -h
> Error parsing command-line options: Missing required options: o, i
> Usage: bin/hdfs oev [OPTIONS] -i INPUT_FILE -o OUTPUT_FILE
> {noformat}
> In code the parsing is happening before the "-h" option is verified
> Can add code to return after initial check.
> {code}
>     if (argv.length == 1 && argv[1] == "-h") {
>       printHelp();
>       return 0;
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to