[ https://issues.apache.org/jira/browse/HDFS-8979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14995976#comment-14995976 ]
Brahma Reddy Battula commented on HDFS-8979: -------------------------------------------- [~liuml07] while committing to branch-2 (resloving the conflicts for branch-2),there are some logical changes happened.you can check following change({{checkOpen();}},which is newly added in branch-2) which leads to {{TestRollingUpgradeRollback#testRollbackWithHAQJM}} fails in branch-2. {code} - RollingUpgradeInfo rollingUpgrade(RollingUpgradeAction action) throws IOException { - TraceScope scope = tracer.newScope("rollingUpgrade"); - try { + RollingUpgradeInfo rollingUpgrade(RollingUpgradeAction action) + throws IOException { + checkOpen(); + try (TraceScope ignored = tracer.newScope("rollingUpgrade")) { return namenode.rollingUpgrade(action); - } finally { - scope.close(); {code} Note: branch-2 patch is not attached in jira. IMO, we can revert this patch for branch-2 and prepare patch for branch-2.then close HDFS-9400. > Clean up checkstyle warnings in hadoop-hdfs-client module > --------------------------------------------------------- > > Key: HDFS-8979 > URL: https://issues.apache.org/jira/browse/HDFS-8979 > Project: Hadoop HDFS > Issue Type: Task > Reporter: Mingliang Liu > Assignee: Mingliang Liu > Fix For: 2.8.0 > > Attachments: HDFS-8979.000.patch, HDFS-8979.001.patch, > HDFS-8979.002.patch > > > This jira tracks the effort of cleaning up checkstyle warnings in > {{hadoop-hdfs-client}} module. -- This message was sent by Atlassian JIRA (v6.3.4#6332)