[
https://issues.apache.org/jira/browse/HDFS-9244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131553#comment-15131553
]
Andrew Wang commented on HDFS-9244:
-----------------------------------
Thanks for the rev, I think we're close:
* Can we add the same preconditions from getEncryptionZoneForPath to the the
getParentEZ method? meaning the javadoc about the needing to hold the lock, the
lock assert, the precondition check. The lock javadoc also should refer to the
FSDirectory lock, there's no manager lock (please fix the existing javadoc on
getEZForPath too while you're at it).
* In createEZ, let's throw FileNotFoundException rather than IOException in the
new check, better to have our exceptions be specific if possible.
* I do still expect more extensive test coverage of nested encryption zones
beyond trash deletes. Some non-exhaustive examples: ensuring correct key is
used when nested, renames within a nested EZ work, renaming a nested file to
the parent EZ does not work, renaming above the parent EZ does not work,
renaming a nested root within the parent and outside the parent works, renaming
a non-nested EZ inside an EZ works.
* Update checkMoveValidity javadoc with these intended behaviors.
> Support nested encryption zones
> -------------------------------
>
> Key: HDFS-9244
> URL: https://issues.apache.org/jira/browse/HDFS-9244
> Project: Hadoop HDFS
> Issue Type: New Feature
> Components: encryption
> Reporter: Xiaoyu Yao
> Assignee: Zhe Zhang
> Attachments: HDFS-9244.00.patch, HDFS-9244.01.patch,
> HDFS-9244.02.patch, HDFS-9244.03.patch, HDFS-9244.04.patch
>
>
> This JIRA is opened to track adding support of nested encryption zone based
> on [~andrew.wang]'s [comment
> |https://issues.apache.org/jira/browse/HDFS-8747?focusedCommentId=14654141&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14654141]
> for certain use cases.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
