[
https://issues.apache.org/jira/browse/HDFS-9847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15216396#comment-15216396
]
Chris Douglas commented on HDFS-9847:
-------------------------------------
bq. StringUtils.toLowerCase() for internationalized string case conversion
For units? Is this a problem?
bq. Use LOG_DEPRECATION.info() for the warnings. That's what it's there for.
Is it? When the config var has been deprecated and replaced
({{blah.blah.seconds}} \-> {{blah.blah}}) that's correct, but this only changes
the type. Someone suppressing deprecation warnings probably also wants to
suppress these, though. Sure.
bq. there's enough use of milliseconds out there, that a long
getTimeDurationMillis() would seem useful
Because it avoids the {{TimeUnit}} import? I disagree that this is useful or
desirable, if we're going to bother with this API at all.
bq. GenericTestUtils has test code for validating exceptions and rethrowing on
failure. Without that: your assert fails but the stack trace of exception at
fault is lost
The latest patches do not throw on failure, but good to know this utility
method.
> HDFS configuration without time unit name should accept friendly time units
> ---------------------------------------------------------------------------
>
> Key: HDFS-9847
> URL: https://issues.apache.org/jira/browse/HDFS-9847
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 2.7.1
> Reporter: Lin Yiqun
> Assignee: Lin Yiqun
> Attachments: HDFS-9847-branch-2.001.patch,
> HDFS-9847-branch-2.002.patch, HDFS-9847-nothrow.001.patch,
> HDFS-9847-nothrow.002.patch, HDFS-9847.001.patch, HDFS-9847.002.patch,
> HDFS-9847.003.patch, HDFS-9847.004.patch, HDFS-9847.005.patch,
> HDFS-9847.006.patch, branch-2-delta.002.txt, timeduration-w-y.patch
>
>
> In HDFS-9821, it talks about the issue of leting existing keys use friendly
> units e.g. 60s, 5m, 1d, 6w etc. But there are som configuration key names
> contain time unit name, like {{dfs.blockreport.intervalMsec}}, so we can make
> some other configurations which without time unit name to accept friendly
> time units. The time unit {{seconds}} is frequently used in hdfs. We can
> updating this configurations first.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
