[ https://issues.apache.org/jira/browse/HDFS-9847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15218541#comment-15218541 ]
Chris Douglas commented on HDFS-9847: ------------------------------------- bq. IMO, we should go ahead without changing the default values and breaking tests in this Jira. Previous versions of the patch were not correct. The unit tests caught this, and trying to start a cluster using a config with units [confirmed|https://issues.apache.org/jira/browse/HDFS-9847?focusedCommentId=15217465&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15217465] it. The handful of tests that do not pass should not be difficult to fix. Please file the JIRA before commit, so deprecation can be tracked. > HDFS configuration without time unit name should accept friendly time units > --------------------------------------------------------------------------- > > Key: HDFS-9847 > URL: https://issues.apache.org/jira/browse/HDFS-9847 > Project: Hadoop HDFS > Issue Type: Sub-task > Affects Versions: 2.7.1 > Reporter: Lin Yiqun > Assignee: Lin Yiqun > Attachments: HDFS-9847-branch-2.001.patch, > HDFS-9847-branch-2.002.patch, HDFS-9847-nothrow.001.patch, > HDFS-9847-nothrow.002.patch, HDFS-9847-nothrow.003.patch, > HDFS-9847.001.patch, HDFS-9847.002.patch, HDFS-9847.003.patch, > HDFS-9847.004.patch, HDFS-9847.005.patch, HDFS-9847.006.patch, > branch-2-delta.002.txt, timeduration-w-y.patch > > > In HDFS-9821, it talks about the issue of leting existing keys use friendly > units e.g. 60s, 5m, 1d, 6w etc. But there are som configuration key names > contain time unit name, like {{dfs.blockreport.intervalMsec}}, so we can make > some other configurations which without time unit name to accept friendly > time units. The time unit {{seconds}} is frequently used in hdfs. We can > updating this configurations first. -- This message was sent by Atlassian JIRA (v6.3.4#6332)