[ https://issues.apache.org/jira/browse/HDFS-9271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391922#comment-15391922 ]
Bob Hansen commented on HDFS-9271: ---------------------------------- Thanks, [~anatoli.shein]. That's looking very close now. test_libhdfs_threaded.c: why did we move doTestGetDefaultBlockSize? hdfds.cc: hdfsFileIsOpenForWrite and hdfsUnbufferFile should simply return false without an error code. We've implemented the functions, we just haven't implemented writing or buffering. hdfds.cc: hdfsAvailalable should set errno to 0 filesystem.h: Why does mkdirs have uint64_t permissions and SetPermissions has int16_t? Should they both be uint16_t since negative values are invalid? Not part of your refactoring, but looks like a problem: hdfs_shim.c: Shouldn't hdfsSeek/hdfsTell do a seek/tell on both the libhdfs and libhdfspp file handles? Also not part of your refactoring, but necessary to get to "no libhdfs in non-write paths": hdfs_shim.c: hdfsConfXXX should go through the libhdfspp interface Minor nits: filesystem.cc: Why can't we set the high bits in GetBlockLocations? Include some comments with your experience/reasoning Notes to self: does hdfsUtime mess up the epoch? > Implement basic NN operations > ----------------------------- > > Key: HDFS-9271 > URL: https://issues.apache.org/jira/browse/HDFS-9271 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs-client > Reporter: Bob Hansen > Assignee: Anatoli Shein > Attachments: HDFS-9271.HDFS-8707.000.patch, > HDFS-9271.HDFS-8707.001.patch, HDFS-9271.HDFS-8707.002.patch, > HDFS-9271.HDFS-8707.003.patch, HDFS-9271.HDFS-8707.004.patch, > HDFS-9271.HDFS-8707.005.patch > > > Expose via C and C++ API: > * mkdirs > * rename > * delete > * stat > * chmod > * chown > * getListing > * setOwner -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org