[
https://issues.apache.org/jira/browse/HDFS-9271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15414239#comment-15414239
]
Anatoli Shein commented on HDFS-9271:
-------------------------------------
[~James C], thank you for the review.
I have addressed your comments as follows:
1) nit: weird space between namespace and type in hdfs.cc
void set_working_directory(std:: string new_directory) { working_directory =
new_directory; }
(/) Done.
2) Right now hdfsFile_internal tracks bytes read. Should this get pushed into
FileHandle?
(/) Done. I moved it to the FileHandle, it does make more sense to keep it
there.
3) pedantic nit: 2 vs 4 space tabs in CheckSystemAndHandle
(/) Fixed.
4) Might still be worth doing calling CheckSystem in hdfsAvailable even if it's
not implemented so latent bugs don't show up in surprising ways once it is
implemented. Same thing for any other functions that are just stubbed in for
now like hdfsUnbufferFile.
(/) Done.
5) Might be worth turning NameNodeOperations::IsHighBitSet into a simple
function in common/util.h. There's other places where that would be nice to use
like checking before casting an unsigned into a signed type (related to
HDFS-10554). Templating the function so it could check any integral type would
be nice too but I can do that later on when I work on the conversion stuff.
Also if you're as bad at counting at counting a long row of 0s as I am it might
be easier to replace the hex literal with something that makes your intention
very clear:
uint64_t firstBit = 0x8000000000000000;
with
uint64_t firstBit = 0x1 << 63;
(/) I moved it to common/util.h and fixed the literal.
Please review the new patch (attached).
> Implement basic NN operations
> -----------------------------
>
> Key: HDFS-9271
> URL: https://issues.apache.org/jira/browse/HDFS-9271
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: Bob Hansen
> Assignee: Anatoli Shein
> Attachments: HDFS-9271.HDFS-8707.000.patch,
> HDFS-9271.HDFS-8707.001.patch, HDFS-9271.HDFS-8707.002.patch,
> HDFS-9271.HDFS-8707.003.patch, HDFS-9271.HDFS-8707.004.patch,
> HDFS-9271.HDFS-8707.005.patch, HDFS-9271.HDFS-8707.006.patch,
> HDFS-9271.HDFS-8707.007.patch
>
>
> Expose via C and C++ API:
> * mkdirs
> * rename
> * delete
> * stat
> * chmod
> * chown
> * getListing
> * setOwner
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
