[
https://issues.apache.org/jira/browse/HDFS-10742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15441127#comment-15441127
]
Arpit Agarwal edited comment on HDFS-10742 at 8/27/16 9:30 AM:
---------------------------------------------------------------
bq. Since Hadoop already uses Lock (including the capabilities omitted from
AutoCloseableLock), it's unlikely we'd standardize on this abstraction.
Hi Chris, you may be right. I can't be sure other developers will prefer using
this instead of manually adding the unlock calls. findbugs doesn't eliminate
human error as committers can miss findbugs warnings (I've been guilty of this
too).
was (Author: arpitagarwal):
bq. It adds a special case for a very common pattern to a subset of the code,
for some mild syntactic sugar.
Hi Chris, you may be right. I can't be sure other developers will prefer using
this instead of manually adding the unlock calls. findbugs doesn't eliminate
human error as committers can miss findbugs warnings (I've been guilty of this
too).
> Measurement of lock held time in FsDatasetImpl
> ----------------------------------------------
>
> Key: HDFS-10742
> URL: https://issues.apache.org/jira/browse/HDFS-10742
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Affects Versions: 3.0.0-alpha2
> Reporter: Chen Liang
> Assignee: Chen Liang
> Attachments: HDFS-10742.001.patch, HDFS-10742.002.patch,
> HDFS-10742.003.patch, HDFS-10742.004.patch, HDFS-10742.005.patch,
> HDFS-10742.006.patch, HDFS-10742.007.patch, HDFS-10742.008.patch
>
>
> This JIRA proposes to measure the time the of lock of {{FsDatasetImpl}} is
> held by a thread. Doing so will allow us to measure lock statistics.
> This can be done by extending the {{AutoCloseableLock}} lock object in
> {{FsDatasetImpl}}. In the future we can also consider replacing the lock with
> a read-write lock.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
