[ https://issues.apache.org/jira/browse/HDFS-10742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15475060#comment-15475060 ]
Erik Krogen edited comment on HDFS-10742 at 9/8/16 9:26 PM: ------------------------------------------------------------ For v16 patch IIUC you actually still have the default set at 2s (FsDatasetImpl line 287). Also all of the other time keys in DFSConfigKeys use a numeric value (of ms or s) rather than a string representation of time, should we keep consistency? Lastly should the new config also be added to {{hdfs-default.xml}}? was (Author: xkrogen): For v16 patch IIUC you actually still have the default set at 2s (FsDatasetImpl line 287) > Measurement of lock held time in FsDatasetImpl > ---------------------------------------------- > > Key: HDFS-10742 > URL: https://issues.apache.org/jira/browse/HDFS-10742 > Project: Hadoop HDFS > Issue Type: Improvement > Components: datanode > Affects Versions: 3.0.0-alpha2 > Reporter: Chen Liang > Assignee: Chen Liang > Attachments: HDFS-10742.001.patch, HDFS-10742.002.patch, > HDFS-10742.003.patch, HDFS-10742.004.patch, HDFS-10742.005.patch, > HDFS-10742.006.patch, HDFS-10742.007.patch, HDFS-10742.008.patch, > HDFS-10742.009.patch, HDFS-10742.010.patch, HDFS-10742.011.patch, > HDFS-10742.012.patch, HDFS-10742.013.patch, HDFS-10742.014.patch, > HDFS-10742.015.patch, HDFS-10742.016.patch > > > This JIRA proposes to measure the time the of lock of {{FsDatasetImpl}} is > held by a thread. Doing so will allow us to measure lock statistics. > This can be done by extending the {{AutoCloseableLock}} lock object in > {{FsDatasetImpl}}. In the future we can also consider replacing the lock with > a read-write lock. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org