[
https://issues.apache.org/jira/browse/HDFS-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15485104#comment-15485104
]
Arpit Agarwal commented on HDFS-10713:
--------------------------------------
Thanks [~hanishakoneru]. Few more comments:
# Log statement in {{writeUnlock}} says _Longest read-lock held interval_. It
should be _Longest write-lock held interval_.
# Move the synchronized block inside the {{if (needReport && readLockInterval
>= this.readLockReportingThreshold)}} so every lock release does not have to
get the {{readUnlockSyncLock}} mutex.
# Nitpick: {{readUnlock}} and {{writeUnlock}} both call {{monotonicNow()}}
twice. We can cache the value returned by the first call to avoid the second
call.
> Throttle FsNameSystem lock warnings
> -----------------------------------
>
> Key: HDFS-10713
> URL: https://issues.apache.org/jira/browse/HDFS-10713
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: logging, namenode
> Reporter: Arpit Agarwal
> Assignee: Hanisha Koneru
> Attachments: HDFS-10713.000.patch, HDFS-10713.001.patch,
> HDFS-10713.002.patch, HDFS-10713.003.patch, HDFS-10713.004.patch,
> HDFS-10713.005.patch
>
>
> The NameNode logs a message if the FSNamesystem write lock is held by a
> thread for over 1 second. These messages can be throttled to at one most one
> per x minutes to avoid potentially filling up NN logs. We can also log the
> number of suppressed notices since the last log message.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
