[
https://issues.apache.org/jira/browse/HDFS-10683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15533957#comment-15533957
]
John Zhuge commented on HDFS-10683:
-----------------------------------
[~jojochuang] From the test output, these 2 test failures seem unrelated to the
patch:
{noformat}
testCannotUpgradeSecondNameNode(org.apache.hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA)
Time elapsed: 0.506 sec <<< ERROR!
java.net.BindException: Port in use: localhost:40448
at sun.nio.ch.Net.bind0(Native Method)
...
testStripedFileChecksumWithMissedDataBlocksRangeQuery15(org.apache.hadoop.hdfs.TestFileChecksum)
Time elapsed: 4.122 sec <<< ERROR!
java.net.BindException: Problem binding to [localhost:59525]
java.net.BindException: Address already in use; For more details see:
http://wiki.apache.org/hadoop/BindException
at sun.nio.ch.Net.bind0(Native Method)
{noformat}
> Make class Token$PrivateToken private
> -------------------------------------
>
> Key: HDFS-10683
> URL: https://issues.apache.org/jira/browse/HDFS-10683
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 2.9.0
> Reporter: John Zhuge
> Assignee: John Zhuge
> Priority: Minor
> Labels: fs, ha, security, security_token
> Attachments: HDFS-10683.001.patch, HDFS-10683.002.patch
>
>
> Avoid {{instanceof}} or typecasting of {{Toke.PrivateToken}} by introducing
> an interface method in {{Token}}. Make class {{Toke.PrivateToken}} private.
> Use a factory method instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
